fix: change es version check to support elasticsearch 8+#4512
fix: change es version check to support elasticsearch 8+#4512kjschnei001 wants to merge 5 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
==========================================
+ Coverage 97.03% 97.04% +0.01%
==========================================
Files 301 300 -1
Lines 17817 17813 -4
==========================================
- Hits 17289 17287 -2
+ Misses 423 421 -2
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The change needs to be demonstrated with CI running successfully against v8. I added it to the matrix, but I think there is some infra issue where a started DB is not recognized by our script, needs investigation. |
kjschnei001
force-pushed
the
es8
branch
2 times, most recently
from
a46720f to
66e5693
Compare
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Signed-off-by: KevinSchneider <kevin.schneider@target.com>
|
I think this is already fixed, we have CI running for esv8. Closing. |
2 participants
Which problem is this PR solving?
_typefield is incompatible in elasticsearch v8, and removing it allows me to successfully write to an index in elasticsearch v8.Short description of the changes